pgsql: Don't spuriously report FD_SETSIZE exhaustion on Windows.

From: Noah Misch <noah(at)leadboat(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Don't spuriously report FD_SETSIZE exhaustion on Windows.
Date: 2023-10-14 22:55:51
Message-ID: E1qrnXz-000aII-Fs@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't spuriously report FD_SETSIZE exhaustion on Windows.

Starting on 2023-08-03, this intermittently terminated a "pgbench -C"
test in CI. It could affect a high-client-count "pgbench" without "-C".
While parallel reindexdb and vacuumdb reach the same problematic check,
sufficient client count and/or connection turnover is less plausible for
them. Given the lack of examples from the buildfarm or from manual
builds, reproducing this must entail rare operating system
configurations. Also correct the associated error message, which was
wrong for non-Windows. Back-patch to v12, where the pgbench check first
appeared. While v11 vacuumdb has the problematic check, reaching it
with typical vacuumdb usage is implausible.

Reviewed by Thomas Munro.

Discussion: https://postgr.es/m/CA+hUKG+JwvTNdcyJTriy9BbtzF1veSRQ=9M_ZKFn9_LqE7Kp7Q@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/90ebcc32d9829204bfd15db82ece3aacd84f40d6

Modified Files
--------------
src/bin/pgbench/pgbench.c | 19 ++++++++++++++-----
src/fe_utils/parallel_slot.c | 37 +++++++++++++++++++++++++++++++++++--
2 files changed, 49 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2023-10-14 22:55:52 pgsql: Don't spuriously report FD_SETSIZE exhaustion on Windows.
Previous Message Tom Lane 2023-10-14 20:13:18 pgsql: Harden xxx_is_visible() functions against concurrent object drop