pgsql: Refactor ListenSocket array.

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Refactor ListenSocket array.
Date: 2023-10-05 12:08:35
Message-ID: E1qoN9e-0009uO-Qd@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Refactor ListenSocket array.

Keep track of the used size of the array. That avoids looping through
the whole array in a few places. It doesn't matter from a performance
point of view since the array is small anyway, but this feels less
surprising and is a little less code. Now that we have an explicit
NumListenSockets variable that is statically initialized to 0, we
don't need the loop to initialize the array.

Allocate the array in PostmasterContext. The array isn't needed in
child processes, so this allows reusing that memory. We could easily
make the array resizable now, but we haven't heard any complaints
about the current 64 sockets limit.

Discussion: https://www.postgresql.org/message-id/7bb7ad65-a018-2419-742f-fa5fd877d338@iki.fi

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e29c46439511a2ba8b447079f2308384a4228c92

Modified Files
--------------
src/backend/libpq/pqcomm.c | 20 ++++------
src/backend/postmaster/postmaster.c | 79 +++++++++++++++----------------------
src/include/libpq/libpq.h | 2 +-
3 files changed, 40 insertions(+), 61 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2023-10-05 14:35:20 pgsql: Push attcompression and attstorage handling into BuildDescForRel
Previous Message Alvaro Herrera 2023-10-05 09:13:54 Re: pgsql: Some refactoring to export json(b) conversion functions