pgsql: Avoid using internal test methods in SSL tests

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Avoid using internal test methods in SSL tests
Date: 2023-09-22 11:40:54
Message-ID: E1qjeWk-005IS5-3V@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid using internal test methods in SSL tests

The SSL tests for pg_ctl restart with an incorrect key passphrase used
the internal _update_pid method to set the pidfile after running pg_ctl
manually instead of using the supplied ->restart method. This refactors
the ->restart method to accept a fail_ok parameter like how ->start and
->stop does, and changes the SSL tests to use this instead. This removes
the need to call internal test module functions.

Reviewed-by: Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>
Reviewed-by: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Discussion: https://postgr.es/m/F81643C4-D7B8-4C6B-AF18-B73839966279@yesql.se

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/33774978c78175095da9e6c276e8bcdb177725f8

Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 31 +++++++++++++++++++++++--------
src/test/ssl/t/001_ssltests.pl | 23 +++++++++--------------
2 files changed, 32 insertions(+), 22 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-09-22 18:52:50 pgsql: Doc: copy-edit the introductory para for the pg_class catalog.
Previous Message Daniel Gustafsson 2023-09-22 09:27:20 pgsql: Avoid potential pfree on NULL on OpenSSL errors