pgsql: Avoid potential pfree on NULL on OpenSSL errors

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Avoid potential pfree on NULL on OpenSSL errors
Date: 2023-09-22 09:27:12
Message-ID: E1qjcRM-005HYT-96@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid potential pfree on NULL on OpenSSL errors

Guard against the pointer being NULL before pfreeing upon an error
returned from OpenSSL. Also handle errors from X509_NAME_print_ex
which also can return -1 on memory allocation errors.

Backpatch down to v15 where the code was added.

Author: Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru>
Discussion: https://postgr.es/m/8db5374d-32e0-6abb-d402-40762511eff2@postgrespro.ru
Backpatch-through: v15

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f720875a4670f94c6d8acd288a2a62c7cabb92dd

Modified Files
--------------
src/backend/libpq/be-secure-openssl.c | 25 +++++++++++++++++--------
1 file changed, 17 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Daniel Gustafsson 2023-09-22 09:27:20 pgsql: Avoid potential pfree on NULL on OpenSSL errors
Previous Message Daniel Gustafsson 2023-09-22 09:26:26 pgsql: Avoid potential pfree on NULL on OpenSSL errors