pgsql: Simplify information schema check constraint deparsing

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Simplify information schema check constraint deparsing
Date: 2023-09-22 05:59:22
Message-ID: E1qjZCE-005FmC-JD@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Simplify information schema check constraint deparsing

The computation of the column
information_schema.check_constraints.check_clause used
pg_get_constraintdef() plus some string manipulation to get the check
clause back out. This ended up with an extra pair of parentheses,
which is only an aesthetic problem, but also with suffixes like "NOT
VALID", which don't belong into that column. We can fix both of these
problems and simplify the code by just using pg_get_expr() instead.

Discussion: https://www.postgresql.org/message-id/799b59ef-3330-f0d2-ee23-8cdfa1740987@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e59fcbd712c777eb2987d7c9ad542a7e817954ec

Modified Files
--------------
src/backend/catalog/information_schema.sql | 3 +--
src/include/catalog/catversion.h | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Daniel Gustafsson 2023-09-22 09:26:26 pgsql: Avoid potential pfree on NULL on OpenSSL errors
Previous Message Tom Lane 2023-09-22 03:12:00 pgsql: Fix COMMIT/ROLLBACK AND CHAIN in the presence of subtransactions