From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Don't crash if cursor_to_xmlschema is used on a non-data-returni |
Date: | 2023-09-18 18:28:33 |
Message-ID: | E1qiIz3-004bfE-3b@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Don't crash if cursor_to_xmlschema is used on a non-data-returning Portal.
cursor_to_xmlschema() assumed that any Portal must have a tupDesc,
which is not so. Add a defensive check.
It's plausible that this mistake occurred because of the rather
poorly chosen name of the lookup function SPI_cursor_find(),
which in such cases is returning something that isn't very much
like a cursor. Add some documentation to try to forestall future
errors of the same ilk.
Report and patch by Boyu Yang (docs changes by me). Back-patch
to all supported branches.
Discussion: https://postgr.es/m/dd343010-c637-434c-a8cb-418f53bda3b8.yangboyu.yby@alibaba-inc.com
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/95f54f0d034eb69349f9134a01441a3cdd311419
Modified Files
--------------
doc/src/sgml/spi.sgml | 13 +++++++++++++
src/backend/utils/adt/xml.c | 4 ++++
2 files changed, 17 insertions(+)
From | Date | Subject | |
---|---|---|---|
Next Message | Nathan Bossart | 2023-09-18 19:19:05 | pgsql: Make binaryheap available to frontend code. |
Previous Message | Alvaro Herrera | 2023-09-18 14:21:19 | pgsql: Fix psql's \? output for \watch |