pgsql: Fix tracking of temp table relation extensions as writes

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix tracking of temp table relation extensions as writes
Date: 2023-09-14 02:22:00
Message-ID: E1qgbzT-003i9x-Sj@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix tracking of temp table relation extensions as writes

Karina figured out that I (Andres) confused BufferUsage.temp_blks_written with
BufferUsage.local_blks_written in fcdda1e4b5.

Tests in core PG can't easily test this, as BufferUsage is just used for
EXPLAIN (ANALYZE, BUFFERS) and pg_stat_statements. Thus this commit adds tests
for this to pg_stat_statements.

Reported-by: Karina Litskevich <litskevichkarina(at)gmail(dot)com>
Author: Karina Litskevich <litskevichkarina(at)gmail(dot)com>
Author: Andres Freund <andres(at)anarazel(dot)de>
Discussion: https://postgr.es/m/CACiT8ibxXA6+0amGikbeFhm8B84XdQVo6D0Qfd1pQ1s8zpsnxQ@mail.gmail.com
Backpatch: 16-, where fcdda1e4b5 was merged

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7369798a83c883a6314b8a8ed6d3063c508de784

Modified Files
--------------
contrib/pg_stat_statements/expected/dml.out | 27 +++++++++++++++++++++++++++
contrib/pg_stat_statements/sql/dml.sql | 19 +++++++++++++++++++
src/backend/storage/buffer/localbuf.c | 2 +-
3 files changed, 47 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2023-09-14 03:16:32 pgsql: Remove redundant result assignment in 004_sync.pl.
Previous Message Michael Paquier 2023-09-14 01:31:20 pgsql: Improve error message on snapshot import in snapmgr.c