pgsql: Fix incorrect logic in plan dependency recording

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix incorrect logic in plan dependency recording
Date: 2023-09-13 23:29:21
Message-ID: E1qgZIO-003h6t-LA@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix incorrect logic in plan dependency recording

Both 50e17ad28 and 29f45e299 mistakenly tried to record a plan dependency
on a function but mistakenly inverted the OidIsValid test. This meant
that we'd record a dependency only when the function's Oid was
InvalidOid. Clearly this was meant to *not* record the dependency in
that case.

50e17ad28 made this mistake first, then in v15 29f45e299 copied the same
mistake.

Reported-by: Tom Lane
Backpatch-through: 14, where 50e17ad28 first made this mistake
Discussion: https://postgr.es/m/2277537.1694301772@sss.pgh.pa.us

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6341cb0b02ae16d7bbb8b4e7ebabf80c551a685e

Modified Files
--------------
src/backend/optimizer/plan/setrefs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2023-09-13 23:35:50 pgsql: Refactor error messages for unsupported providers in pg_locale.c
Previous Message David Rowley 2023-09-13 23:28:56 pgsql: Fix incorrect logic in plan dependency recording