From: | Thomas Munro <tmunro(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix exception safety bug in typcache.c. |
Date: | 2023-09-13 03:10:08 |
Message-ID: | E1qgGGW-003ZfN-7d@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix exception safety bug in typcache.c.
If an out-of-memory error was thrown at an unfortunate time,
ensure_record_cache_typmod_slot_exists() could leak memory and leave
behind a global state that produced an infinite loop on the next call.
Fix by merging RecordCacheArray and RecordIdentifierArray into a single
array. With only one allocation or re-allocation, there is no
intermediate state.
Back-patch to all supported releases.
Reported-by: "James Pang (chaolpan)" <chaolpan(at)cisco(dot)com>
Reviewed-by: Michael Paquier <michael(at)paquier(dot)xyz>
Discussion: https://postgr.es/m/PH0PR11MB519113E738814BDDA702EDADD6EFA%40PH0PR11MB5191.namprd11.prod.outlook.com
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/e2452c2a630a6952289816d9b241d227a38cb93d
Modified Files
--------------
src/backend/utils/cache/typcache.c | 52 +++++++++++++++++++-------------------
src/tools/pgindent/typedefs.list | 1 +
2 files changed, 27 insertions(+), 26 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2023-09-13 03:10:19 | pgsql: Fix exception safety bug in typcache.c. |
Previous Message | Thomas Munro | 2023-09-13 03:09:57 | pgsql: Fix exception safety bug in typcache.c. |