pgsql: Switch psql's TAP test for query cancellation to use IPC::Run::s

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Switch psql's TAP test for query cancellation to use IPC::Run::s
Date: 2023-09-13 01:13:21
Message-ID: E1qgERU-003Z2W-RJ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Switch psql's TAP test for query cancellation to use IPC::Run::signal()

Previously, the test relied on a trick with a shell to retrieve the PID
of the psql session to be stopped with SIGINT, that was skipped on
Windows. This commit changes the test to use IPC::Run::signal()
instead, which still does not work on Windows, but for a different
reason: SIGINT would stop the test before finishing.

This should allow the test to run on non-Windows platforms where PPID is
not supported (like NetBSD), spreading it a bit more across the
buildfarm. And the logic of the test is simpler.

It is the first time in the tree that IPC::Run::signal() is used, so, as
a matter of safety (or just call that as me having cold feet), no
backpatch is done, at least for now.

Author: Yugo NAGATA
Reviewed-by: Fabien Coelho
Discussion: https://postgr.es/m/20230810125935.22c2922ea5250ba79358965b@sraoss.co.jp

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/522a31ac873d7c6b02677f6d119c089a7dd09dd1

Modified Files
--------------
src/bin/psql/t/020_cancel.pl | 38 ++------------------------------------
1 file changed, 2 insertions(+), 36 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2023-09-13 03:09:34 pgsql: Fix exception safety bug in typcache.c.
Previous Message Michael Paquier 2023-09-13 00:54:36 pgsql: Skip psql's TAP test for query cancellation entirely on Windows