pgsql: Fix instability in 031_recovery_conflict.pl.

From: Thomas Munro <tmunro(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix instability in 031_recovery_conflict.pl.
Date: 2023-09-07 02:40:58
Message-ID: E1qe4x0-002kud-77@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix instability in 031_recovery_conflict.pl.

Where the test wants a VACUUM command to generate WAL that would
conflict with a session on the standby, it could transiently fail to do
so if it couldn't acquire a cleanup lock conditionally at that moment on
the primary. VACUUM FREEZE will wait, so use that instead.

No back-patch for now, but that will be needed if/when the test is
re-enabled in back-branches.

Suggested-by: Andres Freund <andres(at)anarazel(dot)de>
Reported-by: Christoph Berg <myon(at)debian(dot)org>
Discussion: https://postgr.es/m/20230812210006.ei7tutzwcr5svyt6%40awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0174c2d213f69a4ba87932de706eedf3fbb5979e

Modified Files
--------------
src/test/recovery/t/031_recovery_conflict.pl | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2023-09-07 05:13:14 pgsql: pg_basebackup: Generate valid temporary slot names under PQbacke
Previous Message Thomas Munro 2023-09-07 00:40:27 pgsql: Fix recovery conflict SIGUSR1 handling.