pgsql: Improve description of keys in tsvector

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve description of keys in tsvector
Date: 2023-09-05 04:58:19
Message-ID: E1qdO8p-002TaS-GF@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve description of keys in tsvector

If all the bits of a key in a tsvector are true (marked with ALLISTRUE),
gtsvectorout() would show the following description:
"0 true bits, 0 false bits"

This is confusing, as all the bits are true, but this would be
equivalent to the information if siglen is 0.

This commit improves the output so as "all true bits" show instead in
this case. Alexander has proposed a regression test for pageinspect,
not included here as it is rather expensive compared to its coverage
value.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/17950-6c80a8d2b94ec695@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/aa0d3504560d40f4300a3d49d1c6c3bfc3b894e5

Modified Files
--------------
src/backend/utils/adt/tsgistidx.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2023-09-05 07:55:03 pgsql: Remove the "snapshot too old" feature.
Previous Message Tom Lane 2023-09-04 13:56:04 Re: pgsql: Fix pg_dump assertion failure when dumping pg_catalog.