pgsql: Fix pg_dump assertion failure when dumping pg_catalog.

From: Jeff Davis <jdavis(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix pg_dump assertion failure when dumping pg_catalog.
Date: 2023-08-22 20:08:17
Message-ID: E1qYXfk-000MI1-Ql@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix pg_dump assertion failure when dumping pg_catalog.

Commit 396d348b04 did not account for the default collation.

Also, use pg_log_warning() instead of Assert().

Discussion: https://postgr.es/m/ce071503fee88334aa70f360e6e4ea14d48305ee.camel%40j-davis.com
Reviewed-by: Michael Paquier
Backpatch-through: 15

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/37188cea0c16f3f27ec65b526ffe12f6469142fc

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 69 ++++++++++++++++++++++++++++++----------
src/bin/pg_dump/t/002_pg_dump.pl | 8 +++++
2 files changed, 61 insertions(+), 16 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Jeff Davis 2023-08-22 20:08:24 pgsql: Fix pg_dump assertion failure when dumping pg_catalog.
Previous Message Andrew Dunstan 2023-08-22 19:18:36 pgsql: Cache by-reference missing values in a long lived context