pgsql: Simplify determining logical replication worker types.

From: Amit Kapila <akapila(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Simplify determining logical replication worker types.
Date: 2023-08-14 03:15:13
Message-ID: E1qVO2y-0000uE-Vc@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Simplify determining logical replication worker types.

We deduce a LogicalRepWorker's type from the values of several different
fields ('relid' and 'leader_pid') whenever logic needs to know it.

In fact, the logical replication worker type is already known at the time
of launching the LogicalRepWorker and it never changes for the lifetime of
that process. Instead of deducing the type, it is simpler to just store it
one time, and access it directly thereafter.

Author: Peter Smith
Reviewed-by: Amit Kapila, Bharath Rupireddy
Discussion: http://postgr.es/m/CAHut+PttPSuP0yoZ=9zLDXKqTJ=d0bhxwKaEaNcaym1XqcvDEg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2a8b40e3681921943a2989fd4ec6cdbf8766566c

Modified Files
--------------
.../replication/logical/applyparallelworker.c | 3 ++-
src/backend/replication/logical/launcher.c | 31 +++++++++++++++-------
src/backend/replication/logical/tablesync.c | 3 ++-
src/include/replication/worker_internal.h | 22 +++++++++++----
src/tools/pgindent/typedefs.list | 1 +
5 files changed, 43 insertions(+), 17 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2023-08-14 05:49:02 pgsql: Change custom wait events to use dynamic shared hash tables
Previous Message Andres Freund 2023-08-12 22:12:33 pgsql: ci: macos: Remove use of -DRANDOMIZE_ALLOCATED_MEMORY