pgsql: Fix pg_dumpall with in-place tablespaces

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix pg_dumpall with in-place tablespaces
Date: 2023-08-08 23:57:09
Message-ID: E1qTWZY-00173o-5F@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix pg_dumpall with in-place tablespaces

In-place tablespaces would be dumped with the path produced by
pg_tablespace_location(), which is in this case a relative path built as
pg_tblspc/OID, but this would fail to restore as such tablespaces need
to use an empty string as location. In order to detect if an in-place
tablespace is used, this commit checks if the path returned is relative
and adapts the dump contents in consequence.

Like the other changes related to in-place tablespaces, no backpatch is
done as these are only intended for development purposes. Rui Zhao has
fixed the code, while the test is from me.

Author: Rui Zhao, Michael Paquier
Discussion: https://postgr.es/m/80c80b4a-b87b-456f-bd46-1ae326601d79.xiyuan.zr@alibaba-inc.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a72d613b4c91462d9405c4e1b05c42d33013c333

Modified Files
--------------
src/bin/pg_dump/pg_dumpall.c | 11 ++++++++++-
src/bin/pg_dump/t/002_pg_dump.pl | 16 ++++++++++++++++
2 files changed, 26 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2023-08-09 08:05:52 pgsql: Fix last remaining uninitialized memory warnings
Previous Message noreply 2023-08-08 21:29:38 pgsql: Tag refs/tags/REL_11_21 was created