pgsql: Improve const use in zlib-using code

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve const use in zlib-using code
Date: 2023-08-07 07:41:27
Message-ID: E1qSurm-000q3r-8x@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve const use in zlib-using code

If we define ZLIB_CONST before including zlib.h, zlib augments some
interfaces with const decorations. By doing that we can keep our own
interfaces cleaner and can remove some unconstify calls.

ZLIB_CONST was introduced in zlib 1.2.5.2 (17 Dec 2011). When
compiling with older zlib releases, you might now get compiler
warnings about discarding qualifiers.

CentOS 6 has zlib 1.2.3, but in 8e278b6576, we removed support for the
OpenSSL release in CentOS 6, so it seems ok to de-support the zlib
release in CentOS 6 as well.

Reviewed-by: Tristan Partin <tristan(at)neon(dot)tech>
Discussion: https://www.postgresql.org/message-id/flat/33462926-bb1e-7cc9-8d92-d86318e8ed1d%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/67c0ef9752ade6dc252a19be8d2259847d4eb78d

Modified Files
--------------
contrib/pgcrypto/pgp-compress.c | 2 +-
src/bin/pg_basebackup/bbstreamer_gzip.c | 2 +-
src/bin/pg_basebackup/walmethods.c | 5 ++---
src/include/c.h | 5 +++++
4 files changed, 9 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Dean Rasheed 2023-08-07 08:32:18 pgsql: Fix RLS policy usage in MERGE.
Previous Message David Rowley 2023-08-07 06:17:32 pgsql: Fix misleading comment in paraminfo_get_equal_hashops