pgsql: worker_spi: Fix race condition in newly-added TAP tests

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: worker_spi: Fix race condition in newly-added TAP tests
Date: 2023-07-29 02:35:59
Message-ID: E1qPZoE-001oIo-P6@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

worker_spi: Fix race condition in newly-added TAP tests

The second portion of the tests had a race condition where it would be
possible for the startup of the dynamic workers to fail, in the event
where the static workers started before them with the library loading in
shared_preload_libraries did not finish to create their respective
schemas. The conflict is caused by the fact that the dynamic and static
workers used the same IDs, overlapping each other, so, for now, switch
the dynamic workers to use different IDs, leading to different schemas
created.

Reported-by: Andres Freund
Discussion: https://postgr.es/m/20230728022332.egqzobhskmlf6ntr@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b68e356a680ee1155b0dc612a89655e98320121a

Modified Files
--------------
src/test/modules/worker_spi/t/001_worker_spi.pl | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2023-07-30 06:26:59 pgsql: Fix pg_rewind with in-place tablespaces when source is remote
Previous Message Nathan Bossart 2023-07-28 17:10:21 pgsql: Harmonize password reuse in vacuumdb, clusterdb, and reindexdb.