pgsql: Fix off-by-one in LimitAdditionalPins()

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix off-by-one in LimitAdditionalPins()
Date: 2023-07-25 03:24:11
Message-ID: E1qO8eg-001Cz7-9x@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix off-by-one in LimitAdditionalPins()

Due to the bug LimitAdditionalPins() could return 0, violating
LimitAdditionalPins()'s API ("One additional pin is always allowed"). This
could be hit when setting shared_buffers very low and using a fair amount of
concurrency.

This bug was introduced in 31966b151e6a.

Author: "Anton A. Melnikov" <aamelnikov(at)inbox(dot)ru>
Reported-by: "Anton A. Melnikov" <aamelnikov(at)inbox(dot)ru>
Reported-by: Victoria Shepard
Discussion: https://postgr.es/m/ae46f2fb-5586-3de0-b54b-1bb0f6410ebd@inbox.ru
Backpatch: 16-

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/bd2f46c6559ddcafe7bae5015ac45b69bc014067

Modified Files
--------------
src/backend/storage/buffer/bufmgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2023-07-25 03:52:32 pgsql: Fix the display of UNKNOWN message type in apply worker.
Previous Message Alvaro Herrera 2023-07-24 15:56:52 pgsql: Make test_decoding ddl.out shorter