| From: | Amit Langote <amitlan(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Code review for commit b6e1157e7d |
| Date: | 2023-07-21 10:29:37 |
| Message-ID: | E1qMnOC-000ax7-HS@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Code review for commit b6e1157e7d
b6e1157e7d made some changes to enforce that
JsonValueExpr.formatted_expr is always set and is the expression that
gives a JsonValueExpr its runtime value, but that's not really
apparent from the comments about and the code manipulating
formatted_expr. This commit fixes that.
Per suggestion from Álvaro Herrera.
Discussion: https://postgr.es/m/20230718155313.3wqg6encgt32adqb%40alvherre.pgsql
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/7c7412cae3ea8f8accdec1022969a9360b74f253
Modified Files
--------------
src/backend/nodes/makefuncs.c | 11 ++++-------
src/backend/nodes/nodeFuncs.c | 4 +---
src/backend/parser/gram.y | 4 +++-
src/backend/parser/parse_expr.c | 17 +++++++++++------
src/include/nodes/makefuncs.h | 3 ++-
src/include/nodes/primnodes.h | 5 +++--
6 files changed, 24 insertions(+), 20 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-07-21 16:00:22 | pgsql: Fix calculation of relid sets for partitionwise child joins. |
| Previous Message | Amit Langote | 2023-07-21 10:29:08 | pgsql: Don't include CaseTestExpr in JsonValueExpr.formatted_expr |