pgsql: Add missing ObjectIdGetDatum() in syscache lookup calls for Oids

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add missing ObjectIdGetDatum() in syscache lookup calls for Oids
Date: 2023-07-20 06:19:05
Message-ID: E1qMN0C-000P1g-70@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add missing ObjectIdGetDatum() in syscache lookup calls for Oids

Based on how postgres.h foes the Oid <-> Datum conversion, there is no
existing bugs but let's be consistent. 17 spots have been noticed as
incorrectly passing down Oids rather than Datums. Aleksander got one,
Zhang two and I the rest.

Author: Michael Paquier, Aleksander Alekseev, Zhang Mingli
Discussion: https://postgr.es/m/ZLUhqsqQN1MOaxdw@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2a990abd79acea4717cc8f982a28f35b6b347ddb

Modified Files
--------------
src/backend/catalog/index.c | 2 +-
src/backend/commands/alter.c | 3 ++-
src/backend/commands/sequence.c | 4 ++--
src/backend/commands/tablecmds.c | 9 +++++----
src/backend/commands/user.c | 2 +-
src/backend/partitioning/partbounds.c | 2 +-
src/backend/partitioning/partdesc.c | 2 +-
src/backend/utils/adt/acl.c | 4 ++--
src/backend/utils/adt/ruleutils.c | 2 +-
src/backend/utils/cache/lsyscache.c | 6 ++++--
src/backend/utils/cache/partcache.c | 3 ++-
11 files changed, 22 insertions(+), 17 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Langote 2023-07-20 08:15:54 pgsql: Pass constructName to transformJsonValueExpr()
Previous Message Michael Paquier 2023-07-20 01:24:21 pgsql: Fix pg_recvlogical upon signal termination