From: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix assertion failure in snapshot building |
Date: | 2023-07-04 15:38:43 |
Message-ID: | E1qGi71-001tEp-9G@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix assertion failure in snapshot building
Clear any potential stale next_phase_at value from the snapshot
builder which otherwise may trip an assertion check ensuring
that there is no next_phase_at value.
This can be reproduced by running 80 concurrent sessions like
the below where $c is a loop counter (assumes there has been
1..$c databases created) :
echo "
CREATE TABLE replication_example(id SERIAL PRIMARY KEY,
somedata int,
text varchar(120));
SELECT 'init' FROM
pg_create_logical_replication_slot('regression_slot_$c',
'test_decoding');
SELECT data FROM
pg_logical_slot_get_changes('regression_slot_$c', NULL,
NULL, 'include-xids', '0',
'skip-empty-xacts', '1');
" | psql -d regress_$c >>psql.log &
Backpatch down to v16.
Bug: #17695
Author: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Reviewed-by: Alexander Lakhin <exclusion(at)gmail(dot)com>
Reported-by: bowenshi <zxwsbg(at)qq(dot)com>
Discussion: https://postgr.es/m/17695-6be9277c9295985f@postgresql.org
Backpatch-through: v16
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/48efb2302bea3b2af8b4bb865edcc70132ee4250
Modified Files
--------------
src/backend/replication/logical/snapbuild.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2023-07-04 15:38:49 | pgsql: Fix assertion failure in snapshot building |
Previous Message | Heikki Linnakangas | 2023-07-04 15:31:31 | pgsql: Ensure that creation of an empty relfile is fsync'd at checkpoin |