| From: | Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Minor cleanups in the BRIN code |
| Date: | 2023-07-02 08:21:33 |
| Message-ID: | E1qFsKr-001UlM-Jn@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Minor cleanups in the BRIN code
BRIN bloom and minmax-multi opclasses were somewhat inconsistent when
dealing with bool variables, assigning to them Datum values etc. While
not a bug, it makes the code harder to understand, so fix that.
While at it, update an incorrect comment copied to bloom opclass from
minmax, talking about strategies not supported by bloom.
Reviewed-by: Heikki Linnakangas
Discussion: https://postgr.es/m/0e1f3350-c9cf-ab62-43a5-5dae314de89c%40enterprisedb.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/28d03feac386c2c68ffaa47f30e6578591ef5c1b
Modified Files
--------------
src/backend/access/brin/brin_bloom.c | 15 +++++++++------
src/backend/access/brin/brin_minmax_multi.c | 24 ++++++++++++------------
2 files changed, 21 insertions(+), 18 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2023-07-02 08:25:34 | pgsql: Introduce bloom_filter_size for BRIN bloom opclass |
| Previous Message | Thomas Munro | 2023-07-02 03:31:01 | pgsql: Trust signalfd on illumos, again. |