pgsql: Don't include outer join relids in lateral_relids bitmapsets.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Don't include outer join relids in lateral_relids bitmapsets.
Date: 2023-06-20 14:30:05
Message-ID: E1qBcMu-002jsh-Jv@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't include outer join relids in lateral_relids bitmapsets.

This avoids an assertion failure when outer joins are rearranged
per identity 3. Listing only the baserels from a PlaceHolderVar's
ph_lateral set should be enough to ensure that the required values
are available when we need to compute the PHV --- it's what we
did before inventing nullingrel sets, after all. It's a bit
unsatisfying; but with beta2 hard upon us, there's not time to
look for an aesthetically cleaner fix.

Richard Guo and Tom Lane

Discussion: https://postgr.es/m/CAMbWs48Jcw-NvnxT23WiHP324wG44DvzcH1j4hc0Zn+3sR9cfg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/efeb12ef0bfef0b5aa966a56bb4dbb1f936bda0c

Modified Files
--------------
src/backend/optimizer/plan/initsplan.c | 16 +++++++++++++---
src/test/regress/expected/join.out | 17 +++++++++++++++++
src/test/regress/sql/join.sql | 7 +++++++
3 files changed, 37 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-06-20 15:10:07 pgsql: Fix another cause of "wrong varnullingrels" planner failures.
Previous Message Tom Lane 2023-06-20 13:53:03 pgsql: Add b334612b8 to .git-blame-ignore-revs.