pgsql: Fix "wrong varnullingrels" for Memoize's lateral references, too

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix "wrong varnullingrels" for Memoize's lateral references, too
Date: 2023-06-13 22:01:44
Message-ID: E1q9C59-001er1-PL@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix "wrong varnullingrels" for Memoize's lateral references, too.

The issue fixed in commit bfd332b3f can also bite Memoize plans,
because of the separate copies of lateral reference Vars made
by paraminfo_get_equal_hashops. Apply the same hacky fix there.

(In passing, clean up shaky grammar in the existing comments
for this function.)

Richard Guo

Discussion: https://postgr.es/m/CAMbWs4-krwk0Wbd6WdufMAupuou_Ua73ijQ4XQCr1Mb5BaVtKQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/63e4f13d2a78124c798165814a679b0534db87a5

Modified Files
--------------
src/backend/optimizer/path/joinpath.c | 55 ++++++++++++++++++++++++++++++-----
src/backend/optimizer/plan/setrefs.c | 10 +++----
src/test/regress/expected/join.out | 21 +++++++++++++
src/test/regress/sql/join.sql | 7 +++++
4 files changed, 81 insertions(+), 12 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tatsuo Ishii 2023-06-14 02:14:10 pgsql: Fix make_etags breakage on certain platforms.
Previous Message Tom Lane 2023-06-13 21:18:01 Re: pgsql: Fix search_path to a safe value during maintenance operations.