pgsql: Don't use _BitScanForward64/_BitScanReverse64 on 32-bit MSVC bui

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Don't use _BitScanForward64/_BitScanReverse64 on 32-bit MSVC bui
Date: 2023-06-07 22:11:56
Message-ID: E1q71Nj-000fD1-NC@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't use _BitScanForward64/_BitScanReverse64 on 32-bit MSVC builds

677319746 added support for making use of MSVC's bit scanning functions.
However, that commit failed to consider 32-bit MSVC builds where the
64-bit versions of these functions are unavailable. This resulted in
compilation failures on 32-bit MSVC.

Here we adjust the code so we fall back on the manual way of finding the
bit positions for 64-bit integers when building on 32-bit MSVC.

Bug: #17967
Reported-by: Youmiu Mo
Discussion: https://postgr.es/m/17967-cd21e34a314141b2@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/53ea2b7ad050ce4ad95c89bb55197209b65886a1

Modified Files
--------------
src/include/port/pg_bitutils.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2023-06-08 11:15:37 pgsql: doc: Fix example command for ALTER FOREIGN TABLE ... OPTIONS.
Previous Message Tomas Vondra 2023-06-07 16:56:28 pgsql: Use per-tuple context in ExecGetAllUpdatedCols