From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Remove over-eager assertion in ExtendBufferedRelTo() |
Date: | 2023-05-21 17:14:01 |
Message-ID: | E1q0md8-0012gq-3x@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Remove over-eager assertion in ExtendBufferedRelTo()
The assertion checked that the size of the relation is not "too large" - but
the code is explicitly dealing with the possibility of another backend
extending the relation concurrently. In that case the new relation size could
be bigger than what the current backend needs, wrongly triggering an assertion
failure.
Unfortunately it is hard to write a reliable and affordable regression tests
for this, as a lot of concurrency is needed to encounter the bug.
Introduced in 31966b151e6a.
Reported-by: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/eabb22525efc40ce0d83580584094a0248ac0682
Modified Files
--------------
src/backend/storage/buffer/bufmgr.c | 1 -
1 file changed, 1 deletion(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Davis | 2023-05-21 19:11:43 | Re: pgsql: Doc: fix some rendering problems in the PDF docs build. |
Previous Message | Andres Freund | 2023-05-21 16:46:35 | pgsql: Optimize walsender wake up logic using condition variables |