| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Convert nullingrels match checks from Asserts to test-and-elog. |
| Date: | 2023-05-17 15:14:16 |
| Message-ID: | E1pzIr2-000Luw-T1@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Convert nullingrels match checks from Asserts to test-and-elog.
It seems like the code that these checks are backstopping may have
a few bugs left in it. Use a test-and-elog so that the tests are
performed even in non-assert builds, and so that we get something
more informative than "server closed the connection" on failure.
Committed separately with the idea that eventually we'll revert
this. It might be awhile though.
Discussion: https://postgr.es/m/3014965.1684293045@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/867be9c0738bef591544d39985f886b7d8e99bf0
Modified Files
--------------
src/backend/optimizer/plan/setrefs.c | 34 +++++++++++++++++++++-------------
1 file changed, 21 insertions(+), 13 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-05-17 15:46:20 | pgsql: Track tlist_vinfo.varnullingrels even in non-Assert builds. |
| Previous Message | Tomas Vondra | 2023-05-17 15:00:59 | pgsql: Advance input pointer when LZ4 compressing data |