| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix incorrect TAP test ordering |
| Date: | 2023-05-15 06:03:18 |
| Message-ID: | E1pyRIk-002Dgn-Ek@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix incorrect TAP test ordering
Using a test function before a possible skip_all is incorrect. If the
skip_all is called, the test output will become incorrect and the test
file will fail.
a4f23f9b3c introduced a new test before skip_all. After discussion,
this doesn't really need to be a test. Instead, we just bail out if
the condition is not satisfied.
Discussion: https://www.postgresql.org/message-id/af5567a1-aea6-fbdb-7e4b-d1e23a43c43b@enterprisedb.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/92155e15d3cfe97758552484acb1583aaf71cda6
Modified Files
--------------
src/bin/pg_amcheck/t/004_verify_heapam.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-05-15 07:02:36 | pgsql: doc: Fix incorrect version list for Windows SDK |
| Previous Message | Peter Eisentraut | 2023-05-15 04:28:31 | pgsql: Fix whitespace inconsistencies |