pgsql: Tighten usage of PSQL_WATCH_PAGER.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Tighten usage of PSQL_WATCH_PAGER.
Date: 2023-05-12 20:11:24
Message-ID: E1pxZ6p-001pGI-Jm@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tighten usage of PSQL_WATCH_PAGER.

Don't use PSQL_WATCH_PAGER when stdin/stdout are not a terminal.
This corresponds to the restrictions on when other commands will
use [PSQL_]PAGER. There isn't a lot of sense in trying to use a
pager in non-interactive cases, and doing so allows an environment
setting to break our tests.

Also, ignore PSQL_WATCH_PAGER if it is set but empty or all-blank,
for the same reasons we ignore such settings of [PSQL_]PAGER (see
commit 18f8f784c).

No documentation change is really needed, since there is nothing
suggesting that these constraints on [PSQL_]PAGER didn't already
apply to PSQL_WATCH_PAGER too. But I rearranged the text
a little to make it read more naturally (IMHO anyway).

Per report from Pavel Stehule. Back-patch to v15 where
PSQL_WATCH_PAGER was introduced.

Discussion: https://postgr.es/m/CAFj8pRDTwFzmEWdA-gdAcUh0ZnxUioSfTMre71WyB_wNJy-8gw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/51b2c08798867cb9788090704b37c4698b456240

Modified Files
--------------
doc/src/sgml/ref/psql-ref.sgml | 31 ++++++++++++++++---------------
src/bin/psql/command.c | 14 ++++++++++----
2 files changed, 26 insertions(+), 19 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Nathan Bossart 2023-05-12 21:19:07 pgsql: Improve error message for pg_create_subscription.
Previous Message Peter Eisentraut 2023-05-12 08:03:50 pgsql: initdb: Set collversion for standard collation UNICODE