From: | Amit Kapila <akapila(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix the race condition in the test case added by commit a6e04b1d |
Date: | 2023-05-09 09:00:23 |
Message-ID: | E1pwJCo-001EyH-W8@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix the race condition in the test case added by commit a6e04b1d20.
The commit a6e04b1d20 added a test to ensure that the invalidated logical
slots don't retain WAL. The test was ensuring that the checkpoint removes
the WAL files corresponding to invalidated logical slots on the standby
node but missed the point that the standby node also had a physical slot
which led to the prevention of WAL file removal. Move the creation of
physical slot on the standby and initialization of cascading standby closer
to the test case that actually required it so that other tests don't get
affected by the presence of the physical slot on standby.
Author: Bertrand Drouvot
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/2fefa454-5a70-2174-ddbf-4a0e41537139@gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c5b7f67fcc8c4a01c82660eb0996a3c697fac283
Modified Files
--------------
.../recovery/t/035_standby_logical_decoding.pl | 36 +++++++++++-----------
1 file changed, 18 insertions(+), 18 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | noreply | 2023-05-09 22:05:00 | pgsql: Tag refs/tags/REL_12_15 was created |
Previous Message | Amit Kapila | 2023-05-09 04:12:37 | pgsql: Fix invalid memory access during the shutdown of the parallel ap |