pgsql: Remove vacuum_defer_cleanup_age

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove vacuum_defer_cleanup_age
Date: 2023-04-24 20:03:08
Message-ID: E1pr2Ox-004jDr-Mo@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove vacuum_defer_cleanup_age

vacuum_defer_cleanup_age was introduced before hot_standby_feedback and
replication slots existed. It is hard to use reasonably - commonly it will
either be set too low (not preventing recovery conflicts, while still causing
some bloat), or too high (causing a lot of bloat). The alternatives do not
have that issue.

That on its own might not be sufficient reason to remove
vacuum_defer_cleanup_age, but it also complicates computation of xid
horizons. See e.g. the bug fixed in be504a3e974. It also is untested.

This commit removes TransactionIdRetreatSafely(), as there are no users
anymore. There might be potential future users, hence noting that here.

Reviewed-by: Daniel Gustafsson <daniel(at)yesql(dot)se>
Reviewed-by: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Reviewed-by: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Discussion: https://postgr.es/m/20230317230930.nhsgk3qfk7f4axls@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1118cd37eb61e6a2428f457a8b2026a7bb3f801a

Modified Files
--------------
doc/src/sgml/config.sgml | 35 ---------
doc/src/sgml/high-availability.sgml | 28 ++-----
src/backend/storage/ipc/procarray.c | 105 ++------------------------
src/backend/storage/ipc/standby.c | 1 -
src/backend/utils/misc/guc_tables.c | 9 ---
src/backend/utils/misc/postgresql.conf.sample | 1 -
src/bin/pg_upgrade/server.c | 5 +-
src/include/storage/standby.h | 1 -
8 files changed, 15 insertions(+), 170 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2023-04-24 22:32:25 Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call
Previous Message Tom Lane 2023-04-24 18:20:04 pgsql: Fix memory leakage in plpgsql DO blocks that use cast expression