From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix Heap rmgr's desc output for infobits arrays. |
Date: | 2023-04-11 22:25:24 |
Message-ID: | E1pmMQV-002bKp-2Z@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix Heap rmgr's desc output for infobits arrays.
Make heap desc routines that output status bit as arrays of constants
avoid outputting array literals that contain superfluous punctuation
characters that complicate parsing the output. Also make sure that no
heap desc routine repeats the same key name (at the same nesting level),
for the same reason. Arguably, these were both oversights in commit
7d8219a4.
In passing, make the desc output code (which covers Heap's DELETE,
UPDATE, HOT_UPDATE, LOCK, and LOCK_UPDATED record types) consistent in
terms of the output order of each field. This order also matches WAL
record struct order. Heap's DELETE desc output now shows the record's
xmax field for the first time (just like UPDATE/HOT_UPDATE records).
Author: Peter Geoghegan <pg(at)bowt(dot)ie>
Reviewed-By: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAH2-Wz=pNYtxiJ2Jx5Lj=fKo1OEZ4GE0p_kct+ugAUTqBwU46g@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/96149a180d56162b0288e8c8ec5ee2c1f076e88b
Modified Files
--------------
src/backend/access/rmgrdesc/heapdesc.c | 120 +++++++++++++++++++--------------
1 file changed, 71 insertions(+), 49 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2023-04-11 22:26:41 | pgsql: Refine the guidelines for rmgrdesc authors. |
Previous Message | Peter Geoghegan | 2023-04-11 21:08:17 | pgsql: Fix xl_heap_lock WAL record field's data type. |