From: | David Rowley <drowley(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Improve ereports for VACUUM's BUFFER_USAGE_LIMIT option |
Date: | 2023-04-11 07:37:11 |
Message-ID: | E1pm8Yw-002V3T-Kb@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Improve ereports for VACUUM's BUFFER_USAGE_LIMIT option
There's no need to check if opt->arg is NULL since defGetString() already
does that and raises an ERROR if it is. Let's just remove that check.
Also, combine the two remaining ERRORs into a single check. It seems
better to give an indication about what sort of values we're looking for
rather than just to state that the value given isn't valid. Make
BUFFER_USAGE_LIMIT uppercase in this ERROR message too. It's already
upper case in one other error message, so make that consistent.
Reported-by: Kyotaro Horiguchi
Discussion: https://postgr.es/m/20230411.102335.1643720544536884844.horikyota.ntt@gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/68a2a437f46716efd54d177edf9dbcc9916c903b
Modified Files
--------------
src/backend/commands/vacuum.c | 33 ++++++++-------------------------
src/test/regress/expected/vacuum.out | 6 +++---
2 files changed, 11 insertions(+), 28 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2023-04-11 07:40:47 | Re: pgsql: Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option |
Previous Message | David Rowley | 2023-04-11 06:53:20 | pgsql: Doc: use "an SQL" consistently rather than "a SQL" |