pgsql: Handle logical slot conflicts on standby

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Handle logical slot conflicts on standby
Date: 2023-04-08 07:11:01
Message-ID: E1pl2iy-0020Hl-7X@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Handle logical slot conflicts on standby

During WAL replay on the standby, when a conflict with a logical slot is
identified, invalidate such slots. There are two sources of conflicts:
1) Using the information added in 6af1793954e, logical slots are invalidated if
required rows are removed
2) wal_level on the primary server is reduced to below logical

Uses the infrastructure introduced in the prior commit. FIXME: add commit
reference.

Change InvalidatePossiblyObsoleteSlot() to use a recovery conflict to
interrupt use of a slot, if called in the startup process. The new recovery
conflict is added to pg_stat_database_conflicts, as confl_active_logicalslot.

See 6af1793954e for an overall design of logical decoding on a standby.

Bumps catversion for the addition of the pg_stat_database_conflicts column.
Bumps PGSTAT_FILE_FORMAT_ID for the same reason.

Author: "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>
Author: Andres Freund <andres(at)anarazel(dot)de>
Author: Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> (in an older version)
Reviewed-by: "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>
Reviewed-by: Andres Freund <andres(at)anarazel(dot)de>
Reviewed-by: Robert Haas <robertmhaas(at)gmail(dot)com>
Reviewed-by: Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>
Reviewed-by: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Reviewed-by: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Reviewed-by: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Discussion: https://postgr.es/m/20230407075009.igg7be27ha2htkbt@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/26669757b6a7665c1069e77e6472bd8550193ca6

Modified Files
--------------
doc/src/sgml/monitoring.sgml | 11 +++++++++++
src/backend/access/gist/gistxlog.c | 2 ++
src/backend/access/hash/hash_xlog.c | 1 +
src/backend/access/heap/heapam.c | 3 +++
src/backend/access/nbtree/nbtxlog.c | 2 ++
src/backend/access/spgist/spgxlog.c | 1 +
src/backend/access/transam/xlog.c | 15 +++++++++++++++
src/backend/catalog/system_views.sql | 3 ++-
src/backend/replication/slot.c | 8 +++++++-
src/backend/storage/ipc/procsignal.c | 3 +++
src/backend/storage/ipc/standby.c | 20 +++++++++++++++++++-
src/backend/tcop/postgres.c | 9 +++++++++
src/backend/utils/activity/pgstat_database.c | 4 ++++
src/backend/utils/adt/pgstatfuncs.c | 3 +++
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_proc.dat | 5 +++++
src/include/pgstat.h | 3 ++-
src/include/storage/procsignal.h | 1 +
src/include/storage/standby.h | 2 ++
src/test/regress/expected/rules.out | 3 ++-
20 files changed, 95 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2023-04-08 08:10:56 pgsql: For cascading replication, wake physical and logical walsenders
Previous Message Andres Freund 2023-04-08 06:09:11 pgsql: Support invalidating replication slots due to horizon and wal_le