From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: psql: set SHELL_ERROR and SHELL_EXIT_CODE in more places. |
Date: | 2023-04-06 21:33:44 |
Message-ID: | E1pkXEl-001jwW-BS@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
psql: set SHELL_ERROR and SHELL_EXIT_CODE in more places.
Make the \g, \o, \w, and \copy commands set these variables
when closing a pipe. We missed doing this in commit b0d8f2d98,
but it seems like a good idea.
There are some remaining places in psql that intentionally don't
update these variables after running a child program:
* pager invocations
* backtick evaluation within a prompt
* \e (edit query buffer)
Corey Huinker and Tom Lane
Discussion: https://postgr.es/m/CADkLM=eSKwRGF-rnRqhtBORRtL49QsjcVUCa-kLxKTqxypsakw@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/31ae2aa9d2c200a0d7d3283d749669a408ec7b65
Modified Files
--------------
doc/src/sgml/ref/psql-ref.sgml | 16 ++++++++++++----
src/bin/psql/command.c | 16 ++--------------
src/bin/psql/common.c | 26 +++++++++++++++++++++++---
src/bin/psql/common.h | 2 ++
src/bin/psql/copy.c | 1 +
src/bin/psql/psqlscanslash.l | 10 ++++------
6 files changed, 44 insertions(+), 27 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2023-04-06 21:38:13 | Re: pgsql: Fix ts_headline() edge cases for empty query and empty search te |
Previous Message | Tom Lane | 2023-04-06 19:52:55 | pgsql: Fix ts_headline() edge cases for empty query and empty search te |