pgsql: Always make a BufferAccessStrategy for ANALYZE

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Always make a BufferAccessStrategy for ANALYZE
Date: 2023-04-06 00:37:28
Message-ID: E1pkDd0-001Zi7-Vq@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Always make a BufferAccessStrategy for ANALYZE

32fbe0239 changed things so we didn't bother allocating the
BufferAccessStrategy during VACUUM (ONLY_DATABASE_STATS); and VACUUM
(FULL), however, it forgot to consider that VACUUM (FULL, ANALYZE) is a
possible combination. That change would have resulted in such a command
allowing ANALYZE to make full use of shared buffers, which wasn't
intended, so fix that.

Reported-by: Melanie Plageman
Discussion: https://postgr.es/m/CAAKRu_bJRKe+v_=OqwC+5sA3j5qv8rqdAwy3+yHaO3wmtfrCRg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bccd6908ca82c6cba0c76b669bc81fc9f3fb60cd

Modified Files
--------------
src/backend/commands/vacuum.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2023-04-06 00:51:23 pgsql: Use ExtendBufferedRelTo() in {vm,fsm}_extend()
Previous Message Michael Paquier 2023-04-06 00:29:39 pgsql: Fix row tracking in pg_stat_statements with extended query proto