pgsql: Copy and store addrinfo in libpq-owned private memory

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Copy and store addrinfo in libpq-owned private memory
Date: 2023-03-29 20:00:19
Message-ID: E1phbxy-000MCs-BL@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Copy and store addrinfo in libpq-owned private memory

This refactors libpq to copy addrinfos returned by getaddrinfo to
memory owned by libpq such that future improvements can alter for
example the order of entries.

As a nice side effect of this refactor the mechanism for iteration
over addresses in PQconnectPoll is now identical to its iteration
over hosts.

Author: Jelte Fennema <postgres(at)jeltef(dot)nl>
Reviewed-by: Aleksander Alekseev <aleksander(at)timescale(dot)com>
Reviewed-by: Michael Banck <mbanck(at)gmx(dot)net>
Reviewed-by: Andrey Borodin <amborodin86(at)gmail(dot)com>
Discussion: https://postgr.es/m/PR3PR83MB04768E2FF04818EEB2179949F7A69@PR3PR83MB0476.EURPRD83.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/44d85ba5a3361dea371d23bd91777ef4c0c4e506

Modified Files
--------------
src/include/libpq/pqcomm.h | 6 ++
src/interfaces/libpq/fe-connect.c | 112 +++++++++++++++++++++++++++-----------
src/interfaces/libpq/libpq-int.h | 7 ++-
src/tools/pgindent/typedefs.list | 1 +
4 files changed, 92 insertions(+), 34 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2023-03-30 03:37:30 pgsql: Fix outdated comments regarding TupleTableSlots
Previous Message Tom Lane 2023-03-29 15:31:44 pgsql: Fix dereference of dangling pointer in GiST index buffering buil