From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Improve a bit the tests of pg_walinspect |
Date: | 2023-03-23 02:51:44 |
Message-ID: | E1pfB3H-004vFM-Q5@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Improve a bit the tests of pg_walinspect
This commit improves the tests of pg_walinspect on a few things:
- Remove aggregates for queries that should fail. If the code is
reworked in such a way that the behavior of these queries is changed,
we would get more input from them, written this way.
- Expect at least one record reported in the valid queries doing scans
across ranges, rather than zero records.
- Adjust a few comments, for consistency.
Author: Bharath Rupireddy
Discussion: https://postgr.es/m/CALj2ACVaoXW3nJD9zq8E66BEf-phgJfFcKRVJq9GXkuX0b3ULQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4f1882b960596c35d62c78fb44e14913eff49a85
Modified Files
--------------
contrib/pg_walinspect/expected/oldextversions.out | 13 +++++----
contrib/pg_walinspect/expected/pg_walinspect.out | 32 ++++++++++-----------
contrib/pg_walinspect/sql/oldextversions.sql | 13 +++++----
contrib/pg_walinspect/sql/pg_walinspect.sql | 34 +++++++++++------------
4 files changed, 47 insertions(+), 45 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2023-03-23 03:21:57 | pgsql: Allow logical replication to copy tables in binary format. |
Previous Message | Thomas Munro | 2023-03-23 00:17:04 | pgsql: Improve the naming of Parallel Hash Join phases. |