pgsql: Fix initdb's handling of min_wal_size and max_wal_size.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix initdb's handling of min_wal_size and max_wal_size.
Date: 2023-03-22 20:37:45
Message-ID: E1pf5DM-004sq5-NF@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix initdb's handling of min_wal_size and max_wal_size.

In commit 3e51b278d, I misinterpreted the coding in setup_config()
as setting min_wal_size and max_wal_size to compile-time-constant
values. But it's not: there's a hidden dependency on --wal-segsize.
Therefore leaving these variables commented out is the wrong thing.
Per report from Andres Freund.

Discussion: https://postgr.es/m/20230322200751.jvfvsuuhd3hgm6vv@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b48af6d174bb39bd688d52795aef2b9c10dd6e8c

Modified Files
--------------
src/bin/initdb/initdb.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-03-22 21:14:24 pgsql: Fix new test case to work on (some?) big-endian architectures.
Previous Message Andres Freund 2023-03-22 20:16:15 Re: pgsql: Teach verify_heapam() to validate update chains within a page.