pgsql: postgres_fdw: Remove useless if-test in GetConnection().

From: Etsuro Fujita <efujita(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: postgres_fdw: Remove useless if-test in GetConnection().
Date: 2023-03-17 09:21:44
Message-ID: E1pd6HP-003xz7-UB@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

postgres_fdw: Remove useless if-test in GetConnection().

Checking whether entry->conn is NULL after doing disconnect_pg_server()
for that entry is pointless, as that function ensures that it is NULL.

Thinko in commit 7fc1a81e4; this would be harmless, so patch HEAD only.

Reviewed-by: Richard Guo and Daniel Gustafsson
Discussion: https://postgr.es/m/CAPmGK169vQ83PQwQkoxO-AK2EeK1EsgsxixedM%2BBLWEAhZ_AqQ%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/39a3bdc9eba50628cecb7e3cada95271180c8744

Modified Files
--------------
contrib/postgres_fdw/connection.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2023-03-17 09:39:03 pgsql: Improve several permission-related error messages.
Previous Message Thomas Munro 2023-03-17 07:43:34 pgsql: libpq: Use modern socket flags, if available.