From: | David Rowley <drowley(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix incorrect logic for determining safe WindowAgg run condition |
Date: | 2023-03-17 02:50:50 |
Message-ID: | E1pd0B7-003vOE-Ku@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix incorrect logic for determining safe WindowAgg run conditions
The logic added in 9d9c02ccd to determine when a qual can be used as a
WindowClause run condition failed to correctly check for subqueries in the
qual. This was being done correctly for normal subquery qual pushdowns,
it's just that 9d9c02ccd failed to follow the lead on that.
This also fixes various other cases where transforming the qual into a
WindowClause run condition in the subquery should have been disallowed.
Bug: #17826
Reported-by: Anban Company
Discussion: https://postgr.es/m/17826-7d8750952f19a5f5@postgresql.org
Backpatch-through: 15, where 9d9c02ccd was introduced.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/eb7d043c9bbadb75a87385113c578f1b30e9d195
Modified Files
--------------
src/backend/optimizer/path/allpaths.c | 185 ++++++++++++++++++++++------------
src/test/regress/expected/window.out | 43 +++++---
src/test/regress/sql/window.sql | 17 +++-
3 files changed, 161 insertions(+), 84 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2023-03-17 02:51:23 | pgsql: Fix incorrect logic for determining safe WindowAgg run condition |
Previous Message | Andres Freund | 2023-03-17 02:38:38 | pgsql: tests: Minimize syslog activity by slapd |