From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Improve handling of psql \watch's interval argument |
Date: | 2023-03-16 00:33:30 |
Message-ID: | E1pcbYg-003jli-Fg@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Improve handling of psql \watch's interval argument
A failure in parsing the interval value defined in the \watch command
was silently switched to 1s of interval between two queries, which can
be confusing. This commit improves the error handling, and a couple of
tests are added to check after:
- An incorrect value.
- An out-of-range value.
- A negative value.
A value of zero is able to work now, meaning that there is no interval
of time between two queries in a \watch loop. No backpatch is done, as
it could break existing applications.
Author: Andrey Borodin
Reviewed-by: Kyotaro Horiguchi, Nathan Bossart, Michael Paquier
Discussion: https://postgr.es/m/CAAhFRxiZ2-n_L1ErMm9AZjgmUK=qS6VHb+0SaMn8sqqbhF7How@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6f9ee74d45aa7c1836b6c12b6e2a958327c16ab5
Modified Files
--------------
src/bin/psql/command.c | 18 +++++++++++++++---
src/bin/psql/t/001_basic.pl | 17 +++++++++++++++++
2 files changed, 32 insertions(+), 3 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2023-03-16 00:36:52 | pgsql: Add .gitignore to ldap_password_func |
Previous Message | Andrew Dunstan | 2023-03-15 22:32:32 | pgsql: MSVC: Don't build ldap_password_func if not building with ldap |