From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Support PlaceHolderVars in MERGE actions. |
Date: | 2023-03-15 15:59:28 |
Message-ID: | E1pcTXE-003gMH-0W@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Support PlaceHolderVars in MERGE actions.
preprocess_targetlist thought PHVs couldn't appear here.
It was mistaken, as per report from Önder Kalacı.
Surveying other pull_var_clause calls, I noted no similar errors,
but I did notice that qual_is_pushdown_safe's assertion about
!contain_window_function was pointless, because the following
pull_var_clause call would complain about them anyway. In HEAD
only, remove the redundant Assert and improve the commentary.
Discussion: https://postgr.es/m/CACawEhUuum-gC_2S3sXLTcsk7bUSPSHOD+g1ZpfKaDK-KKPPWA@mail.gmail.com
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/3908d6ae115801cc61486b286ab71d91c2cdbb99
Modified Files
--------------
src/backend/optimizer/prep/preptlist.c | 12 +++++-------
src/test/regress/expected/merge.out | 21 +++++++++++++++++++++
src/test/regress/sql/merge.sql | 10 ++++++++++
3 files changed, 36 insertions(+), 7 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2023-03-15 20:38:28 | pgsql: Add a hook for modifying the ldapbind password |
Previous Message | Alvaro Herrera | 2023-03-15 08:35:56 | pgsql: doc: Add lists of modules trusted/obsolete |