pgsql: Fix misbehavior in contrib/pg_trgm with an unsatisfiable regex.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix misbehavior in contrib/pg_trgm with an unsatisfiable regex.
Date: 2023-03-11 17:15:55
Message-ID: E1pb2p0-003314-PH@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix misbehavior in contrib/pg_trgm with an unsatisfiable regex.

If the regex compiler can see that a regex is unsatisfiable
(for example, '$foo') then it may emit an NFA having no arcs.
pg_trgm's packGraph function did the wrong thing in this case;
it would access off the end of a work array, and with bad luck
could produce a corrupted output data structure causing more
problems later. This could end with wrong answers or crashes
in queries using a pg_trgm GIN or GiST index with such a regex.

Fix by not trying to de-duplicate if there aren't at least 2 arcs.

Per bug #17830 from Alexander Lakhin. Back-patch to all supported
branches.

Discussion: https://postgr.es/m/17830-57ff5f89bdb02b09@postgresql.org

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b18327489b3be5c30ae51eaf24479da7c0af1aaa

Modified Files
--------------
contrib/pg_trgm/expected/pg_word_trgm.out | 6 ++++++
contrib/pg_trgm/sql/pg_word_trgm.sql | 3 +++
contrib/pg_trgm/trgm_regexp.c | 26 ++++++++++++++++----------
3 files changed, 25 insertions(+), 10 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Jeff Davis 2023-03-11 18:20:33 Re: pgsql: Add standard collation UNICODE
Previous Message Andrew Dunstan 2023-03-11 13:31:00 Re: pgsql: Add standard collation UNICODE