| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Improve/correct comments |
| Date: | 2023-03-09 09:00:37 |
| Message-ID: | E1paC8a-002ej6-Sw@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Improve/correct comments
Change comments for pg_cryptohash_init(), pg_cryptohash_update(),
pg_cryptohash_final() in cryptohash.c to match cryptohash_openssl.c.
In particular, the claim that these functions were "designed" to never
fail was incorrect, since by design callers need to be prepared to
handle failures, for compatibility with the cryptohash_openssl.c
versions.
Reviewed-by: Daniel Gustafsson <daniel(at)yesql(dot)se>
Discussion: https://www.postgresql.org/message-id/301F4EDD-27B9-460F-B462-B9DB2BDE4ACF@yesql.se
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/36ea345f8fa616fd9b40576310e54145aa70c1a1
Modified Files
--------------
src/common/cryptohash.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2023-03-09 09:34:12 | Re: pgsql: Run pgindent on libpq's fe-auth.c, fe-auth-scram.c and fe-connec |
| Previous Message | Peter Eisentraut | 2023-03-09 07:15:48 | pgsql: Disallow specifying ICU rules unless locale provider is ICU |