pgsql: Reword overly-optimistic comment about backup checksum verificat

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Reword overly-optimistic comment about backup checksum verificat
Date: 2023-03-06 15:41:47
Message-ID: E1pZCyB-002CxM-0R@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Reword overly-optimistic comment about backup checksum verification.

The comment implies that a single retry is sufficient to avoid
spurious checksum failures, but in fact no number of retries is
sufficient for that purpose. Update the comment accordingly.

Patch by me, reviewed by Michael Paquier.

Discussion: http://postgr.es/m/CA+TgmoZ_fFAoU6mrHt9QBs+dcYhN6yXenGTTMRebZNhtwPwHyg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e76cbb6cd64d9c9cdf76a56318ba5249bf694b69

Modified Files
--------------
src/backend/backup/basebackup.c | 20 +++++++++++++++-----
1 file changed, 15 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-03-06 18:11:06 pgsql: Fill EState.es_rteperminfos more systematically.
Previous Message Robert Haas 2023-03-06 15:28:17 pgsql: Remove an old comment that doesn't seem especially useful.