pgsql: Rework pg_input_error_message(), now renamed pg_input_error_info

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Rework pg_input_error_message(), now renamed pg_input_error_info
Date: 2023-02-27 23:08:48
Message-ID: E1pWmbw-0012fB-7g@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Rework pg_input_error_message(), now renamed pg_input_error_info()

pg_input_error_info() is now a SQL function able to return a row with
more than just the error message generated for incorrect data type
inputs when these are able to handle soft failures, returning more
contents of ErrorData, as of:
- The error message (same as before).
- The error detail, if set.
- The error hint, if set.
- SQL error code.

All the regression tests that relied on pg_input_error_message() are
updated to reflect the effects of the rename.

Per discussion with Tom Lane and Andrew Dunstan.

Author: Nathan Bossart
Discussion: https://postgr.es/m/139a68e1-bd1f-a9a7-b5fe-0be9845c6311@dunslane.net

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b8da37b3ada2e547983538b3e49f8079f85ce120

Modified Files
--------------
contrib/cube/expected/cube.out | 8 +-
contrib/cube/sql/cube.sql | 2 +-
contrib/hstore/expected/hstore.out | 16 +--
contrib/hstore/sql/hstore.sql | 4 +-
contrib/intarray/expected/_int.out | 18 ++--
contrib/intarray/sql/_int.sql | 8 +-
contrib/isn/expected/isn.out | 18 ++--
contrib/isn/sql/isn.sql | 8 +-
contrib/ltree/expected/ltree.out | 28 ++---
contrib/ltree/sql/ltree.sql | 8 +-
contrib/seg/expected/seg.out | 24 +++--
contrib/seg/sql/seg.sql | 8 +-
doc/src/sgml/func.sgml | 33 +++---
src/backend/utils/adt/misc.c | 44 ++++++--
src/include/catalog/pg_proc.dat | 10 +-
src/test/regress/expected/arrays.out | 8 +-
src/test/regress/expected/bit.out | 40 ++++----
src/test/regress/expected/boolean.out | 8 +-
src/test/regress/expected/box.out | 16 +--
src/test/regress/expected/char.out | 8 +-
src/test/regress/expected/char_1.out | 8 +-
src/test/regress/expected/char_2.out | 8 +-
src/test/regress/expected/date.out | 16 +--
src/test/regress/expected/domain.out | 34 +++---
src/test/regress/expected/enum.out | 21 ++--
.../regress/expected/float4-misrounded-input.out | 8 +-
src/test/regress/expected/float4.out | 8 +-
src/test/regress/expected/float8.out | 8 +-
src/test/regress/expected/geometry.out | 16 +--
src/test/regress/expected/inet.out | 24 ++---
src/test/regress/expected/int2.out | 24 ++---
src/test/regress/expected/int4.out | 8 +-
src/test/regress/expected/int8.out | 8 +-
src/test/regress/expected/interval.out | 16 +--
src/test/regress/expected/json.out | 8 +-
src/test/regress/expected/json_encoding.out | 8 +-
src/test/regress/expected/json_encoding_1.out | 8 +-
src/test/regress/expected/jsonb.out | 16 +--
src/test/regress/expected/jsonpath.out | 22 ++--
src/test/regress/expected/line.out | 40 ++++----
src/test/regress/expected/lseg.out | 8 +-
src/test/regress/expected/macaddr.out | 16 +--
src/test/regress/expected/macaddr8.out | 16 +--
src/test/regress/expected/money.out | 16 +--
src/test/regress/expected/multirangetypes.out | 16 +--
src/test/regress/expected/numeric.out | 24 ++---
src/test/regress/expected/oid.out | 32 +++---
src/test/regress/expected/path.out | 16 +--
src/test/regress/expected/pg_lsn.out | 8 +-
src/test/regress/expected/point.out | 8 +-
src/test/regress/expected/polygon.out | 16 +--
src/test/regress/expected/privileges.out | 24 ++---
src/test/regress/expected/rangetypes.out | 40 ++++----
src/test/regress/expected/regproc.out | 114 ++++++++++-----------
src/test/regress/expected/rowtypes.out | 16 +--
src/test/regress/expected/strings.out | 24 ++---
src/test/regress/expected/tid.out | 16 +--
src/test/regress/expected/time.out | 16 +--
src/test/regress/expected/timestamp.out | 16 +--
src/test/regress/expected/timestamptz.out | 16 +--
src/test/regress/expected/timetz.out | 16 +--
src/test/regress/expected/tstypes.out | 24 ++---
src/test/regress/expected/uuid.out | 8 +-
src/test/regress/expected/varchar.out | 8 +-
src/test/regress/expected/varchar_1.out | 8 +-
src/test/regress/expected/varchar_2.out | 8 +-
src/test/regress/expected/xid.out | 32 +++---
src/test/regress/expected/xml.out | 10 +-
src/test/regress/expected/xml_1.out | 4 +-
src/test/regress/expected/xml_2.out | 8 +-
src/test/regress/sql/arrays.sql | 2 +-
src/test/regress/sql/bit.sql | 10 +-
src/test/regress/sql/boolean.sql | 2 +-
src/test/regress/sql/box.sql | 4 +-
src/test/regress/sql/char.sql | 2 +-
src/test/regress/sql/date.sql | 4 +-
src/test/regress/sql/domain.sql | 10 +-
src/test/regress/sql/enum.sql | 6 +-
src/test/regress/sql/float4.sql | 2 +-
src/test/regress/sql/float8.sql | 2 +-
src/test/regress/sql/geometry.sql | 4 +-
src/test/regress/sql/inet.sql | 6 +-
src/test/regress/sql/int2.sql | 6 +-
src/test/regress/sql/int4.sql | 2 +-
src/test/regress/sql/int8.sql | 2 +-
src/test/regress/sql/interval.sql | 4 +-
src/test/regress/sql/json.sql | 2 +-
src/test/regress/sql/json_encoding.sql | 2 +-
src/test/regress/sql/jsonb.sql | 4 +-
src/test/regress/sql/jsonpath.sql | 8 +-
src/test/regress/sql/line.sql | 10 +-
src/test/regress/sql/lseg.sql | 2 +-
src/test/regress/sql/macaddr.sql | 4 +-
src/test/regress/sql/macaddr8.sql | 4 +-
src/test/regress/sql/money.sql | 4 +-
src/test/regress/sql/multirangetypes.sql | 4 +-
src/test/regress/sql/numeric.sql | 6 +-
src/test/regress/sql/oid.sql | 8 +-
src/test/regress/sql/path.sql | 4 +-
src/test/regress/sql/pg_lsn.sql | 2 +-
src/test/regress/sql/point.sql | 2 +-
src/test/regress/sql/polygon.sql | 4 +-
src/test/regress/sql/privileges.sql | 6 +-
src/test/regress/sql/rangetypes.sql | 10 +-
src/test/regress/sql/regproc.sql | 34 +++---
src/test/regress/sql/rowtypes.sql | 4 +-
src/test/regress/sql/strings.sql | 6 +-
src/test/regress/sql/tid.sql | 4 +-
src/test/regress/sql/time.sql | 4 +-
src/test/regress/sql/timestamp.sql | 4 +-
src/test/regress/sql/timestamptz.sql | 4 +-
src/test/regress/sql/timetz.sql | 4 +-
src/test/regress/sql/tstypes.sql | 6 +-
src/test/regress/sql/uuid.sql | 2 +-
src/test/regress/sql/varchar.sql | 2 +-
src/test/regress/sql/xid.sql | 8 +-
src/test/regress/sql/xml.sql | 4 +-
117 files changed, 768 insertions(+), 682 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2023-02-27 23:38:52 pgsql: Fix expected output of xml_2.out
Previous Message Tom Lane 2023-02-27 22:21:37 pgsql: Suppress compiler warnings in new pgstats code.