pgsql: Consider a failed process as a failed test in pg_regress

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Consider a failed process as a failed test in pg_regress
Date: 2023-02-23 08:50:49
Message-ID: E1pV7JQ-000Gv1-Gp@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Consider a failed process as a failed test in pg_regress

Commit 55de145d1cf added reporting of child process failures, but the
test suite is still allowed to pass even if the process failed. Since
regress tests are higher level tests, a false positive is more likely
in this case so report failed test processes as failed tests.

Reported-by: Andres Freund <andres(at)anarazel(dot)de>
Discussion: https://postgr.es/m/82C46B5E-1821-4039-82C2-56BCA5992989@yesql.se
Discussion: https://postgr.es/m/20221122235636.4frx7hjterq6bmls@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/337903a16fb0980950a98a17c388b28da8642446

Modified Files
--------------
src/test/regress/pg_regress.c | 37 +++++++++++++++++++++++++------------
1 file changed, 25 insertions(+), 12 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Dean Rasheed 2023-02-23 11:01:16 pgsql: Fix multi-row DEFAULT handling for INSERT ... SELECT rules.
Previous Message Andres Freund 2023-02-22 22:47:05 pgsql: Add static assertion ensuring sizeof(ExprEvalStep) <= 64 bytes