pgsql: Remove obsolete pgindent options --code-base and --build

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove obsolete pgindent options --code-base and --build
Date: 2023-02-13 13:26:35
Message-ID: E1pRYqo-000vzU-U3@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove obsolete pgindent options --code-base and --build

Now that we have the sources for pg_bsd_indent in our code base these
are redundant.

It is now required to provide a list of files or directories to pgindent,
either by using --commit or on the command line. The equivalent of
previously running pgindent with no parameters is now `pgindent .`

Some extra checks are also added. duplicate files in the file list are
skipped, and there is a warning if no files are specified.

If the --commit option is used, the script now chdir's to the source
root, as git always reports files relative to that. (Fixes a gripe from
Justin Pryzby)

Reviewed by Tom Lane

Discussion: https://postgr.es/m/842819.1676219054@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b16259b3c1897cf90855a94e5cb126d6c75e3cf3

Modified Files
--------------
src/tools/pgindent/pgindent | 101 +++++-----------------------------------
src/tools/pgindent/pgindent.man | 12 +----
2 files changed, 14 insertions(+), 99 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-02-13 16:45:45 pgsql: Fix thinkos in have_unsafe_outer_join_ref; reduce to Assert chec
Previous Message Alvaro Herrera 2023-02-13 13:10:43 pgsql: Fix object identity string for transforms