pgsql: Remove useless casts to (void *) in hash_search() calls

Remove useless casts to (void *) in hash_search() calls

Some of these appear to be leftovers from when hash_search() took a
char * argument (changed in 5999e78fc45dcb91784b64b6e9ae43f4e4f68ca2).

Since after this there is some more horizontal space available, do
some light reformatting where suitable.

Reviewed-by: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Discussion: https://www.postgresql.org/message-id/flat/fd9adf5d-b1aa-e82f-e4c7-263c30145807%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/54a177a948b0a773c25c6737d1cc3cc49222a526

Modified Files
--------------
contrib/postgres_fdw/shippable.c | 12 ++----
src/backend/access/gist/gistbuild.c | 4 +-
src/backend/access/gist/gistbuildbuffers.c | 2 +-
src/backend/access/transam/xlogutils.c | 6 +--
src/backend/catalog/storage.c | 4 +-
src/backend/optimizer/util/predtest.c | 2 +-
src/backend/parser/parse_oper.c | 6 +--
src/backend/replication/logical/relation.c | 6 +--
src/backend/replication/logical/reorderbuffer.c | 34 ++++-------------
src/backend/replication/pgoutput/pgoutput.c | 2 +-
src/backend/storage/buffer/buf_table.c | 6 +--
src/backend/storage/buffer/bufmgr.c | 17 ++-------
src/backend/storage/buffer/localbuf.c | 15 +++-----
src/backend/storage/lmgr/lock.c | 50 ++++++++++++-------------
src/backend/storage/smgr/smgr.c | 6 +--
src/backend/storage/sync/sync.c | 4 +-
src/backend/tsearch/ts_typanalyze.c | 4 +-
src/backend/utils/adt/array_typanalyze.c | 4 +-
src/backend/utils/adt/ri_triggers.c | 8 ++--
src/backend/utils/cache/attoptcache.c | 6 +--
src/backend/utils/cache/relcache.c | 12 +++---
src/backend/utils/cache/relfilenumbermap.c | 6 +--
src/backend/utils/cache/spccache.c | 6 +--
src/backend/utils/cache/ts_cache.c | 14 +++----
src/backend/utils/cache/typcache.c | 8 ++--
src/backend/utils/time/combocid.c | 2 +-
src/pl/plpgsql/src/pl_comp.c | 6 +--
src/pl/plpgsql/src/pl_exec.c | 2 +-
28 files changed, 108 insertions(+), 146 deletions(-)